Re: [PATCH] swsuspend breakage in 2.6.17-git

[Linus Torvalds]

On Mon, 26 Jun 2006, Shaohua Li wrote:
>
> Below is from ACPI spec 3.0 (p405). From my understanding, OS should
> save/restore NVS memory ?

Ok, that's what it looks like.

However, the patches clearly don't actually work right now. 

I suspect part of the problem is that Linux will normally create the 
"struct page *" array (and page tables) only for the pages marked as being 
usable RAM, so when you start to try to save specialty pages, we won't 
have page tables set up for them, nor will we have any "struct page" for 
them either.

Also, clearly this also breaks other architectures.

So I'm reverting them from my tree for now, I just have to test that I got 
it right first (there were some partial dependencies on the patches as 
follow-on cleanups).

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/