Re: [PATCH] Kconfig for radio cards to allow VIDEO_V4L1_COMPAT

From: Mauro Carvalho Chehab
Date: Mon Jun 26 2006 - 09:06:04 EST


Jon,

Em Dom, 2006-06-25 às 13:40 -0400, Jon Smirl escreveu:
> In Kconfig all of the radio cards depend on VIDEO_V4L1. But V4L1 has
> been deprecated and replaced with V4L2. V4L2 offers a V4L1
> compatibility layer. Should the Kconfig for these devices be changed
> to depend on (VIDEO_V4L1. || VIDEO_V4L1_COMPAT)? I'm not the
> maintainer for this but they seem to build ok.
No, it isn't. V4L1_COMPAT gets a userspace request, using the obsoleted
V4L1 API and converts into a V4L2 call to be handled by a V4L2 driver.

All radio stuff at kernel are still using the old obsoleted V4L1 API,
and requires some changes to be V4L2 compliant. The correct fix is to
replace the old calls to V4L2 calls, and include videodev2.h header
instead of videodev.h.

After those changes, we should move the dependencies to be VIDEO_V4L2,
instead of VIDEO_V4L1.

Cheers,
Mauro.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/