[PATCH 005 of 14] knfsd: nfsd4: fix open_confirm locking

From: NeilBrown
Date: Tue Jun 27 2006 - 03:19:43 EST


From: J. Bruce Fields <bfields@xxxxxxxxxxxxxx>

Fix an improper unlock in an error path.

Signed-off-by: J. Bruce Fields <bfields@xxxxxxxxxxxxxx>

### Diffstat output
./fs/nfsd/nfs4state.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff .prev/fs/nfsd/nfs4state.c ./fs/nfsd/nfs4state.c
--- .prev/fs/nfsd/nfs4state.c 2006-06-27 14:36:03.000000000 +1000
+++ ./fs/nfsd/nfs4state.c 2006-06-27 14:36:03.000000000 +1000
@@ -2252,8 +2252,9 @@ nfsd4_open_confirm(struct svc_rqst *rqst
(int)current_fh->fh_dentry->d_name.len,
current_fh->fh_dentry->d_name.name);

- if ((status = fh_verify(rqstp, current_fh, S_IFREG, 0)))
- goto out;
+ status = fh_verify(rqstp, current_fh, S_IFREG, 0);
+ if (status)
+ return status;

nfs4_lock_state();

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/