Re: [PATCH]microcode update driver rewrite - takes 2

From: Chuck Ebbert
Date: Tue Jun 27 2006 - 04:18:20 EST


In-Reply-To: <1151376693.21189.52.camel@xxxxxxxxxxxxxxxxxxxxxxx>

On Tue, 27 Jun 2006 10:51:33 +0800, Shaohua Li wrote:

> This is the rewrite of microcode update driver. Changes:

> + printk(KERN_ERR "microcode: error! Bad data in microcode "
> + "data file\n");

I counted five of these "generic" error messages. I know the original
driver had this problem too because I hit it and couldn't tell where
the message came from.

Could you change these messages so they're unique and they describe the
actual problem better? E.g. "data too large for user buffer" etc.?

--
Chuck
"You can't read a newspaper if you can't read." --George W. Bush
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/