[Patch] Off by one in drivers/usb/input/yealink.c

[Eric Sesterhenn]

hi,

another off by one spotted by coverity (id #485),
we loop exactly one time too often

Signed-off-by: Eric Sesterhenn <snakebyte@xxxxxx>

--- linux-2.6.17-git11/drivers/usb/input/yealink.c.orig	2006-06-28 00:29:46.000000000 +0200
+++ linux-2.6.17-git11/drivers/usb/input/yealink.c	2006-06-28 00:30:04.000000000 +0200
@@ -350,7 +350,7 @@ static int yealink_do_idle_tasks(struct 
 		val = yld->master.b[ix];
 		if (val != yld->copy.b[ix])
 			goto send_update;
-	} while (++ix < sizeof(yld->master));
+	} while (++ix < sizeof(yld->master)-1);
 
 	/* nothing todo, wait a bit and poll for a KEYPRESS */
 	yld->stat_ix = 0;


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/