Re: 2.6.17-mm2

From: Andrew Morton
Date: Wed Jun 28 2006 - 15:09:54 EST


On Wed, 28 Jun 2006 07:43:14 -0700
"Martin J. Bligh" <mbligh@xxxxxxxxxx> wrote:

> Andrew Morton wrote:
> > On Wed, 28 Jun 2006 03:42:15 -0700
> > Andrew Morton <akpm@xxxxxxxx> wrote:
> >
> >
> >>his is caused by the vsprintf() changes. Right now, if you do
> >>
> >> snprintf(buf, 4, "1111111111111");
> >>
> >>the memory at `buf' gets [31 31 31 31 00], which is not good.
> >>
> >>This'll plug it, but I didn't check very hard whether it still has any
> >>off-by-ones, or if breaks the intent of Jeremy's patch. I think it's OK..
>
> Aha, you're a genius!

That's not what my kids say.

> How the hell did you figure that one out?

Found a way to reproduce it - do `cat /proc/slabinfo > /dev/null' in a
tight loop. With that happening, a little two-way wasn't able to make
it through `dbench 4' without soiling the upholstery. Then bisection-searching.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/