Re: 2.6.17-mm2

From: Andrew Morton
Date: Wed Jun 28 2006 - 15:48:07 EST


On Wed, 28 Jun 2006 12:22:02 -0700
Jeremy Fitzhardinge <jeremy@xxxxxxxx> wrote:

> Andrew Morton wrote:
> > Found a way to reproduce it - do `cat /proc/slabinfo > /dev/null' in a
> > tight loop. With that happening, a little two-way wasn't able to make
> > it through `dbench 4' without soiling the upholstery. Then bisection-searching.
> >
> It's surprising it was so subtle. I'd been running with that code for a
> month or so without a peep of problem...
>

It'll only bite if someone does snprintf() into a too-short buffer. That's
rare (it's usually a bug). But it looks like the seq_file() code does it
when someone is trying to generate more than PAGE_SIZE's worth of data.
Like /proc/slabinfo.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/