Re: IS_ERR Threshold Value

[Nathan Scott]

On Wed, Jun 28, 2006 at 05:13:33PM -0600, Erik Frederiksen wrote:
> On Wed, 2006-06-28 at 16:41, Nathan Scott wrote:
> > Hmm, I'm not sure I understand the XFS side of your report here - on
> ...
> XFS has acted correctly.  The only reason I bring it up is this is how
> the bug was brought to my attention.  

Ah, OK.  When you said this...

| it caused an alignment exception in the XFS open call when quota has
| been exceeded in the linux-mips 2.6.14 kernel.  I think that the XFS
| code has changed enough that this bug isn't in newer versions, though I
| haven't done a thorough investigation.

... I couldn't think of anything we'd changed in XFS that would have
addressed this since that kernel version.

> If there won't be any strange side effects (I don't have the experience
> to accurately comment on this), I think turning the threshold value up
> to something we can get away with in IS_ERR_VALUE() would be
> appropriate.

Seems right to me too, FWIW.

cheers.

-- 
Nathan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/