Re: [PATCH 1/6] PCI-Express AER implemetation

[Grant Grundler]

Yanmin,
Just one nit...

On Thu, Jun 29, 2006 at 09:12:27AM +0800, Zhang, Yanmin wrote:
> Patch 1 consists of the pciaer-howto.txt document.
...
> +In existing Linux kernels, 2.4.x and 2.6.x, there is no root service
> +driver available to manage the PCI Express advanced error reporting
> +extended capability structure.

"existing Linux kernels" won't mean anything 3 years.
You might be more specific such as "All kernels before 2.6.18 released..."


...
> +To provide a solution to these BIOS issues requires the PCI Express AER
> +Root driver that provides:
> +
> +- 	A mechanism for the OS and application to determine if a fatal
> +	error is fatal to the system, OS, or application increasing
> +	uptime.

The word "mechanism" is used frequently.
I wonder if sometimes (like above) "infrastructure" is meant.

> +8. Frequent Asked Questions

I'd be tempted to make the FAQ the next section after the introduction.

hth,
grant
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/