Re: [PATCH -mm] ide_end_drive_cmd(): avoid instruction pipelinestall

From: Alan Cox
Date: Fri Jun 30 2006 - 13:09:27 EST


Ar Gwe, 2006-06-30 am 18:13 +0200, ysgrifennodd Andreas Mohr:
> Use an independently-formatted "unsigned int" for data instead of a
> restrictive "u16" to avoid instruction fetch pipeline stalls
> probably caused by the byte calculations later.

drivers/ide is on its way out. I'm also curious that this shows up given
that the inw() is going to cause a PCI sequence and stall the CPU
entirely for ages anyway.

NAK because
1. This is a gcc problem
2. Not everyone is using an intel x86-32 box which has such problems
3. IDE is in life-support mode and the relatives are already planning
the flowers.

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/