[PATCH] EXT3: ext3 block bitmap leakage

[Kirill Korotaev]

This patch fixes ext3 block bitmap leakage,
which leads to the following fsck messages on
_healthy_ filesystem:
Block bitmap differences:  -64159 -73707

All kernels up to 2.6.17 have this bug.

Found by
   Vasily Averin <vvs@xxxxx> and Andrey Savochkin <saw@xxxxxxxxxx>
Test case triggered the issue was created by
   Dmitry Monakhov <dmonakhov@xxxxx>

Signed-Off-By: Vasiliy Averin <vvs@xxxxx>
Signed-Off-By: Andrey Savochkin <saw@xxxxxxxxxx>
Signed-Off-By: Kirill Korotaev <dev@xxxxxxxxxx>
CC: Dmitry Monakhov <dmonakhov@xxxxx>

---

 fs/ext3/inode.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

8c6f6cf38bc9b04edc69c2869ae1e6c584584b4f
diff --git a/fs/ext3/inode.c b/fs/ext3/inode.c
index bcd86f6..d8f5a9b 100644
--- a/fs/ext3/inode.c
+++ b/fs/ext3/inode.c
@@ -570,6 +570,7 @@ static int ext3_alloc_branch(handle_t *h
 
 	branch[0].key = cpu_to_le32(parent);
 	if (parent) {
+		keys = 1;
 		for (n = 1; n < num; n++) {
 			struct buffer_head *bh;
 			/* Allocate the next block */
-- 
1.3.3

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/