Re: [RFC][patch 01/44] Consolidate flags for request_irq

[Thomas Gleixner]

On Sat, 2006-07-01 at 17:49 -0700, Andrew Morton wrote:
> On Sat, 01 Jul 2006 14:54:19 -0000
> Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
> 
> > Move the interrupt related SA_ flags out of linux/signal.h and rename
> > them to IRQF_ . This moves the interrupt related flags out of the signal
> > namespace and allows to remove the architecture dependencies.
> > 
> > SA_INTERRUPT is not needed by userspace and glibc so it can be removed
> > safely. The existing SA_ constants are kept for easy transition and will
> > be removed after a 6 month grace period.
> 
> You seem to have removed SA_PERCPU_IRQ without replacing it.
> 
> drivers/char/mmtimer.c: In function `mmtimer_init':
> drivers/char/mmtimer.c:690: error: `IRQF_PERCPU' undeclared (first use in this function)
> drivers/char/mmtimer.c:690: error: (Each undeclared identifier is reported only once
> drivers/char/mmtimer.c:690: error: for each function it appears in.)

should go after

#define IRQF_TIMER             0x00000200
+defibe IRQF_PERCPU		0x00000400

	tglx



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/