Re: isa_memcpy_fromio

[Stephen Clark]

Arjan van de Ven wrote:

> > Would someone recommend how this should be changed?
> >
> >    
>
> Hi,
>
> the kernel already has a full DMI decoder, this module appears to just
> try to duplicate it (at least judging on the snippet you pasted). It'd
> be a lot better if the module would just use the existing DMI layer...
> If it did that then it doesn't need isa_memcpy_fromio() *at all*...
>
> see the drivers/firmware/dmi_scan.c file for the linux DMI layer code.
>
> Greetings,
>   Arjan van de Ven
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
>  
Hi,

Your right - I didn't even look at the beginning of the module - since I 
was just compiling
it after upgrading to 2.6.17-1.2139_FC5.

From the beginning of the file:
/*
* dmi.c -- to get DMI information
*
* This code originally came from file arch/i386/kernel/dmi_scan.c from
* Linux kernel version 2.4.18
*

Thanks,
Steve

--

"They that give up essential liberty to obtain temporary safety, 
deserve neither liberty nor safety."  (Ben Franklin)

"The course of history shows that as a government grows, liberty 
decreases."  (Thomas Jefferson)



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/