Re: [PATCH 7/7] iosched: introduce deadline_kick_page()

[Fengguang Wu]

Jens,

On Wed, Jun 28, 2006 at 01:27:32PM +0200, Jens Axboe wrote:
> > The overhead of deadline_kick_page() becomes large when the request is
> > large (256 pages). But I guess there's way to optimize it:
> > - most requests will be consisted of a set of continuous pages, i.e. a
> >   range comparison will be sufficient.
> > - for a system with lots of queued requests(>100), maybe the gain can
> >   well pay for the overheads?
> 
> Sorry, there's just no way that something like that is acceptable for
> inclusion. I don't care much about the overhead numbers (I can see from
> the code that it sucks :-), I wanted to see some numbers on what
> scenarios this helps performance and by how much.

Ok, thanks. I hope that I'll be able to bring with some performance
numbers the next time :-)

Regards,
Wu
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/