Re: [PATCH 38 of 39] IB/ipath - More changes to support InfiniPath on PowerPC 970 systems

From: Michael S. Tsirkin
Date: Tue Jul 04 2006 - 01:13:38 EST


Quoting r. Anton Blanchard <anton@xxxxxxxxx>:
> Subject: Re: [PATCH 38 of 39] IB/ipath - More changes to support InfiniPath on PowerPC 970 systems
>
>
> Hi,
>
> > Please fix the generic code if it doesn't provide the facility
> > you need at the moment. Don't shoe horn it into your driver
> > just to make up for that.
>
> Ive had 3 drivers asking for write combining recently so I agree this is
> a good idea. How about ioremap_wc as suggested by Willy:
>
> http://marc.theaimsgroup.com/?l=linux-kernel&m=114374741828040&w=2

Hmm ... I think ioremap_wc isn't sufficient by itself to make drivers using
write-combined memory, portable. Here's another thread on a related subject:

http://lkml.org/lkml/2006/2/24/347

--
MST
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/