Re: [PATCH 1/2] x86-64 TIF flags for debug regs and io bitmap in ctxsw

[Andi Kleen]

On Tuesday 04 July 2006 09:51, Arjan van de Ven wrote:
> > -		}
> > -	}
> > +	if (unlikely((task_thread_info(next_p)->flags & _TIF_WORK_CTXSW))
> > +	    || test_tsk_thread_flag(prev_p, TIF_IO_BITMAP))
> > +		__switch_to_xtra(prev_p, next_p, tss);
> 
> well isn't this replacing an if() (which isn't cheap but also not
> expensive, due to unlikely()) with an atomic operation (which *is*
> expensive) ?

Where do you see an atomic operation?

Also on x86-64 unlikely is an no-op.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/