Re: [PATCH] Limit VIA and SIS AGP choices to x86

[Andrew Morton]

On Wed, 5 Jul 2006 11:57:25 -0600
Matthew Wilcox <matthew@xxxxxx> wrote:

> As far as I am aware, Alpha, PPC and IA64 don't have VIA or SIS AGP
> chipsets available.
> 
> ...
>
>  config AGP_SIS
>  	tristate "SiS chipset support"
> -	depends on AGP
> +	depends on AGP && X86

I never know what to do here.

Sure, the driver will not be used on that architecture.  But there is some
benefit in being able to cross-compile that driver on other architectures
anyway.  Sometimes it will pick up missed #includes, sometimes printk
mismatches, various other assumptions which might be OK for x86 right now
but which might cause problems in the future.

Need to balance a very minor con against some very minor pros ;)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/