Re: [PATCH-2.4] 2 oopses in ethtool

From: Jeff Garzik
Date: Wed Jul 05 2006 - 17:28:32 EST


Willy Tarreau wrote:
Hi Marcelo,

I got an oops today with 2.4.33-rc2 when playing ethtool games on my TG3
NIC. It was caused by a typo in ethtool.c, and while fixing it, I discovered
a second one.

David, a quick check showed that 2.6.17.1 has the first one fixed but not
second one (ethtool_set_pauseparam), so you might want to merge it too.

Cheers,
Willy

From: Willy Tarreau <willy@wtap.(none)>
Date: Wed, 5 Jul 2006 22:34:52 +0200
Subject: [PATCH] ethtool: two oopses in ethtool_set_coalesce() and ethtool_set_pauseparam()

The function pointers which were checked were for their get_* counterparts.
Typically a copy-paste typo.

Signed-off-by: Willy Tarreau <w@xxxxxx>

ACK

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/