Re: [PATCH 5/6] FDPIC: Add coredump capability for the ELF-FDPIC binfmt [try #3]

[David Howells]

Andrew Morton <akpm@xxxxxxxx> wrote:

> > +#define roundup(x, y)  ((((x) + ((y) - 1)) / (y)) * (y))
> 
> The GFS2 tree has 
> 
> ...
> +#define DIV_ROUND_UP(n,d) (((n) + (d) - 1) / (d))

They aren't exactly equivalent.

In any case, we probably shouldn't be using divide, but should rather be using
shifts since the divisors are powers of two.  I wonder if the compiler will
make the substitution...

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/