Re: [PATCH 2/3] disallow modular binfmt_elf32

[Martin Schwidefsky]

On Mon, 2006-07-10 at 08:06 +0200, Heiko Carstens wrote:
> On Sat, Jul 08, 2006 at 08:05:54PM +0200, Christoph Hellwig wrote:
> > Currently most architectures either always build binfmt_elf32 in the
> > kernel image or make it a boolean option.  Only sparc64 and s390 allow
> > to build it modularly.  This patch turns the option into a boolean
> > aswell because elf requires various symbols that shouldn't be available
> > to modules.  The most urgent one is tasklist_lock whos export this patch
> > series kills, but there are others like force_sgi aswell.
> > [...] 
> > Index: linux-2.6/arch/s390/Kconfig
> > ===================================================================
> > --- linux-2.6.orig/arch/s390/Kconfig	2006-07-06 14:21:17.000000000 +0200
> > +++ linux-2.6/arch/s390/Kconfig	2006-07-08 19:08:46.000000000 +0200
> > @@ -119,7 +119,7 @@
> >  	default y
> >  
> >  config BINFMT_ELF32
> > -	tristate "Kernel support for 31 bit ELF binaries"
> > +	bool "Kernel support for 31 bit ELF binaries"
> >  	depends on COMPAT
> >  	help
> 
> Martin and I discussed this already a few days ago. This config option
> should go away on s390, since everybody who wants CONFIG_COMPAT also wants
> CONFIG_BINFMT_ELF32. See patch below which applies on top of yours:

Yes, the removal of the BINFMT_ELF32 Kconfig option has been part of the
s390 Kconfig cleanup patch as well, it is supposed to go away.

-- 
blue skies,
  Martin.

Martin Schwidefsky
Linux for zSeries Development & Services
IBM Deutschland Entwicklung GmbH

"Reality continues to ruin my life." - Calvin.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/