Re: [patch 2.6.18-rc1] genirq: {en,dis}able_irq_wake() need refcounting too

[Ingo Molnar]

* David Brownell <david-b@xxxxxxxxxxx> wrote:

> It's not just "normal" mode operation that needs refcounting for the 
> {en,dis}able_irq() calls ... "wakeup" mode calls need it too, for the 
> very same reasons.
> 
> This patch adds that refcounting.  I expect that some ARM drivers will 
> be triggering the new warning, but this call isn't yet widely used. 
> (Which is probably why the bug has lingered this long...)

Acked-by: Ingo Molnar <mingo@xxxxxxx>

we should also add disable_irq_wake() / enable_irq_wake() APIs and start 
migrating most ARM users over to the new APIs, agreed? That makes the 
APIs more symmetric and the code more readable too.

	Ingo

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/