Re: [PATCH v2] cirrus-logic-framebuffer-i2c-support.patch

[Krzysztof Halasa]

"Antonino A. Daplas" <adaplas@xxxxxxx> writes:

> Why don't you create a separate function for this, ie cirrusfb_create_i2c()
> or something. This way, we eliminate the #ifdef/#endif inside the function.

#ifdef inside a function isn't a problem, while unnecessary complication
(= worse readability) is.
-- 
Krzysztof Halasa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/