Re: [PATCH v2] cirrus-logic-framebuffer-i2c-support.patch

[Antonino A. Daplas]

Krzysztof Halasa wrote:
> "Antonino A. Daplas" <adaplas@xxxxxxx> writes:
> 
>> There are better reasons (ie, smaller patch), but worse readability is not
>> one of them.
>>
>> I could more easily grasp the code flow of cirrusfb_register() if you
>> just inserted "cirrusfb_create_i2c_buses()" instead of:
> 
> Feel free to add another patch, while I don't see a need I have nothing
> against :-)

No, you fix the patch.  And while your at it, check your Kconfig
dependencies, ie check for impossible combinations such as CONFIG_I2C=m,
CONFIG_FB_CIRRUS=y.

Tony
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/