Re: [RFC][PATCH 5/9] -Wshadow: variables named 'up' clash with up()

[Jesper Juhl]

On 10/07/06, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
> > -static inline void uid_hash_insert(struct user_struct *up, struct list_head *hashent)
> > +static inline void uid_hash_insert(struct user_struct *_up, struct list_head *hashent)
> >  {
>
> Please never use such ugly names.  A simply 'u' as variable name would do it
> instead in most places.
Ok, will do.
Thank you for the feedback.

--
Jesper Juhl <jesper.juhl@xxxxxxxxx>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/