Re: functions returning 0 on success [was: [PATCH] Fix a memory leakin the i386 setup code]

[Michael Tokarev]

Michael Tokarev wrote:
[]
> Ofcourse, later you understand that do_something() returns 0
> on failure, and the code is correct.  But the first impression
> (again, for me anyway) is that it's wrong.
> 
> In such cases when a routine returns 0 on error, I usually write
> it this way:
....
s/error/success/g.  Blah ;)
> 
>    if (request_resource() != 0)
>      fail()
[..]
/mjt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/