[PATCH] appledisplay/backlight (Depmod errors on2.6.17.4/2.6.18-rc1/2.6.18-rc1-mm1)

[Randy.Dunlap]

> > >> CONFIG_FB=n, CONFIG_BACKLIGHT_CLASS_DEVICE=m should not be possible in
> > >> 2.6.18-rc1-mm1 and 2.6.18-rc1.  Can you run kconfig again?
> > >>
> > >> Tony
> >
> > I tested with make menuconfig, and it's not possible to set lcd/backlight
> > options if CONFIG_FB is not set.

Tony, it is possiblle when the USB APPLEDISPLAY option is set and it selects
backlight options without regard for FB.
 
> WARNING: /lib/modules/2.6.18-rc1-mm1/kernel/drivers/video/backlight/backlight.ko 
> needs unknown symbol fb_unregister_client
> WARNING: /lib/modules/2.6.18-rc1-mm1/kernel/drivers/video/backlight/backlight.ko 
> needs unknown symbol fb_register_client

This patch fixes it for me.  Is it the right thing to do?
---

From: Randy Dunlap <rdunlap@xxxxxxxxxxxx>

appledisplay calls fb_register_client() so needs to depend on FB.

Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxx>
---
 drivers/usb/misc/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-2618-rc1mm1.orig/drivers/usb/misc/Kconfig
+++ linux-2618-rc1mm1/drivers/usb/misc/Kconfig
@@ -163,7 +163,7 @@ config USB_IDMOUSE
 
 config USB_APPLEDISPLAY
 	tristate "Apple Cinema Display support"
-	depends on USB
+	depends on USB && FB
 	select BACKLIGHT_LCD_SUPPORT
 	select BACKLIGHT_CLASS_DEVICE
 	help

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/