Re: [PATCH] fbdev: Statically link the framebuffer notification functions

[Jon Smirl]

On 7/11/06, Antonino A. Daplas <adaplas@xxxxxxxxx> wrote:
> > The code looks ok but this sure smells like inter_module_*.
>
> I assure you, there is no smell of inter_module_* here. What scenario
> are you afraid of?

Dangling references during the load/unload process. That was
inter_module's problem.

> > I guess
> > inter_module had to deal with arbitrary users and this code is dealing
> > with a fixed set of clients which makes it more manageable.
> >
> > Have you considered making this a generic service and not fb specific?
> >
>
> It's basically a wrapper to the notifier_call_chain, that's as generic
> as it can get. And yes, it's not fb_specific (meaning, there's no need
> for the client module to know fbdev internals), that's why the lcd and
> backlight subsystem can take advantage of it.

The generic code could create notifier chains with a name. The modules
would then use the name to attach. Now you don't need the fb_notifier
code.

--
Jon Smirl
jonsmirl@xxxxxxxxx
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/