Re: [PATCH] irqtrace-option-off-compile-fix

[Tim Chen]

On Tue, 2006-07-11 at 20:05 +0200, Arjan van de Ven wrote: 
> On Tue, 2006-07-11 at 09:36 -0700, Tim Chen wrote:
> > On Tue, 2006-07-11 at 19:13 +0200, Arjan van de Ven wrote:
> > > On Tue, 2006-07-11 at 09:23 -0700, Tim Chen wrote:
> > > > I was testing on x86_64 and turned off the option in
> > > > arch/x86_64/Kconfig.debug. 
> > > > 
> > > > When the option is turned off, the following functions become undefined:
> > > > local_irq_disable()           
> > > > local_irq_enable()             
> > > > local_irq_save(flags)          
> > > > local_irq_restore(flags)       
> > > > safe_halt() 
> > > > local_save_flags()
> > > > irqs_disabled()
> > > > irqs_disabled_flags(flags)                   
> > > > 
> > > > It seems plausible that some users may want to avoid the overhead of
> > > > tracing IRQFLAGS by turning the option off.
> > > 
> > > eh that is a different config option!
> > 
> > My typo, it is TRACE_IRQFLAGS_SUPPORT in arch/x86_64/Kconfig.debug.
> 
> 
> that should never ever be user setable. That just says if you have
> support for the api.
> 
> The one you want is CONFIG_TRACE_IRQFLAGS .. which is the one that
> actually turns the tracing on
> 

I could not turn off CONFIG_TRACE_IRQFLAGS_SUPPORT in .config directly. 
The command "scripts/kconfig/conf -s arch/x86_64/Kconfig" in Makefile
overwrites changes made to CONFIG_TRACE_IRQFLAGS_SUPPORT in .config
file.  So this is always turned on in .config if the option
TRACE_IRQFLAGS_SUPPORT is set in arch/x86_64/Kconfig.debug.  I may be
missing something.  Any suggestions?
  





-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/