Re: please revert kthread from loop.c

[Hugh Dickins]

On Tue, 11 Jul 2006, Serge E. Hallyn wrote:
> > But not good for me.  Gets further e.g. 170 iterations,
> > but then hangs while kthread_stop waits for completion.
> 
> After getting much more familiar with the code, here is a more invasive,
> but pretty heavily tested patch.

I didn't study your patch in detail: as you say, more invasive,
but if it really does the job then it's an improvement, removing
some mystery from loop_thread().  And it does work fine for me -
well, I tested with your next little race addition, and Andrew's
on top of that (with lo->state typo fixed to lo->lo_state); but
I haven't tried your latest refinement from today.

Thanks,
Hugh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/