Re: [PATCH] Add memcpy_cachebypass, a copy routine that tries to keep cache pressure down

[Andi Kleen]

Bryan O'Sullivan <bos@xxxxxxxxxxxxxx> writes:
> + * memcpy_cachebypass - memcpy-compatible copy routine, using streaming loads
> + * @dest: destination address
> + * @src: source address (will not be cached)
> + * @count: number of bytes to copy
> + *
> + * Use streaming loads and normal stores for a special-case copy where
> + * we know we won't be reading the source again, but will be reading the
> + * destination again soon.
> + */

For what CPU did you optimize that function?   Comment missing for that.
Also the comment should state that you're caching the target.
Also I trust you ran it through a comprehensive memcpy-all-cases tester?

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/