Re: [PATCH] reiserfs: fix handling of device names with /'s in them

[Eric Dumazet]

On Wednesday 12 July 2006 18:42, Jeff Mahoney wrote:
>  On systems with block devices containing slashes (virtual dasd, cciss,
>  etc), reiserfs will fail to initialize /proc/fs/reiserfs/<dev> due to
>  it being interpreted as a subdirectory. The generic block device code
>  changes the / to ! for use in the sysfs tree. This patch uses that
>  convention.
>
>  Tested by making dm devices use dm/<number> rather than dm-<number>

Your patch handles at most one slash. But the description mentions 'slashes' 
(ie several slashes)

> +	if (s)
> +		*s = '!';

Maybe you need a loop

while (s) {
	*s = '!';
	s = strchr(s, '/');
}

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/