Re: [PATCH] reiserfs: fix handling of device names with /'s in them

[Andrew Morton]

On Wed, 12 Jul 2006 20:51:47 -0700
Hans Reiser <reiser@xxxxxxxxxxx> wrote:

> Andrew Morton wrote:
> 
> >On Wed, 12 Jul 2006 12:42:28 -0400
> >Jeff Mahoney <jeffm@xxxxxxxx> wrote:
> >
> >  
> >
> >> On systems with block devices containing slashes (virtual dasd, cciss,
> >> etc), reiserfs will fail to initialize /proc/fs/reiserfs/<dev> due to
> >> it being interpreted as a subdirectory. The generic block device code
> >> changes the / to ! for use in the sysfs tree. This patch uses that
> >> convention.
> >>    
> >>
> >
> >Isn't it a bit dumb of us to be putting slashes in the device names anyway?
> > It would be better, if poss, to alter dasd/cciss/etc and stop all these
> >s@/@!@everywhere games.
> >
> >
> >  
> >
> Isn't better to ask why there is a problem with the /'s?  It would be
> bad for Linux as a design to prevent passing arbitrary tail ends of
> filenames off to arbitrary plugins of some kind.  In general, in
> namespace design, you want to allow delegating the job of
> resolving/interpreting the tail end of a file that the front end has
> identified as something that can interpret it.
> 
> Forgive me, I probably understand something wongly about procfs and this
> issue....
> 

It's a question of being *practical*.  Your observations are in the realm
of the theoretical.

Software sucks, and we get along better by not provoking it.  So don't put
spaces, let alone slashes into strings which we offer to userspace.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/