Re: Random panics seen in 2.6.18-rc1

[Ingo Molnar]

* Andrew Morton <akpm@xxxxxxxx> wrote:

> > Any suggestions of how to avoid the parameter passing? (without ugly 
> > #ifdeffery)
> 
> No, I don't see a way apart from inlining __cache_free(), or inlining 
> cache_free_alien() into both kfree() and kmem_cache_free(), both of 
> which are unattractive.

furthermore, cache_free_alien() is a NOP on non-NUMA, so the cost on 
non-NUMA is really small.

but ... i think gcc ought to be able to figure out that the parameter is 
totally unused on !LOCKDEP - all functions involved are static, and we 
are using -funit-at-a-time already. That should make the parameter 
passing totally zero-cost.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/