Re: [PATCH 1/5] UML - Fix ZONE_HIGHMEM compilation error

[Andrew Morton]

On Wed, 12 Jul 2006 12:39:43 -0400
Jeff Dike <jdike@xxxxxxxxxxx> wrote:

> References to ZONE_HIGHMEM need to depend on CONFIG_HIGHMEM.
> 

There are several such references in mm/page_alloc.c

> 
> Index: linux-2.6.17/arch/um/kernel/mem.c
> ===================================================================
> --- linux-2.6.17.orig/arch/um/kernel/mem.c	2006-07-12 11:29:02.000000000 -0400
> +++ linux-2.6.17/arch/um/kernel/mem.c	2006-07-12 11:29:11.000000000 -0400
> @@ -226,7 +226,9 @@ void paging_init(void)
>  	for(i=0;i<sizeof(zones_size)/sizeof(zones_size[0]);i++) 

I spy an ARRAY_SIZE().

>  		zones_size[i] = 0;
>  	zones_size[ZONE_DMA] = (end_iomem >> PAGE_SHIFT) - (uml_physmem >> PAGE_SHIFT);
> +#ifdef CONFIG_HIGHMEM
>  	zones_size[ZONE_HIGHMEM] = highmem >> PAGE_SHIFT;
> +#endif
>  	free_area_init(zones_size);
>  

Maybe this is an rc1-mm1 fix?  Did Christoph's patches break UML, perhaps??
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/