Re: [patch] lockdep: core, fix rq-lock handling on __ARCH_WANT_UNLOCKED_CTXSW

[Ralf Baechle]

On Wed, Jul 12, 2006 at 10:26:39PM +0200, Ingo Molnar wrote:

> Subject: lockdep: core, fix rq-lock handling on __ARCH_WANT_UNLOCKED_CTXSW
> From: Ingo Molnar <mingo@xxxxxxx>
> 
> on platforms that have __ARCH_WANT_UNLOCKED_CTXSW set and want to 
> implement lock validator support there's a bug in rq->lock handling: in 
> this case we dont 'carry over' the runqueue lock into another task - but 
> still we did a spinlock_release() of it. Fix this by making the 
> spinlock_release() in context_switch() dependent on 
> !__ARCH_WANT_UNLOCKED_CTXSW.
> 
> (Reported by Ralf Baechle on MIPS, which has __ARCH_WANT_UNLOCKED_CTXSW. 
> This fixes a lockdep-internal BUG message on such platforms.)
> 
> Signed-off-by: Ingo Molnar <mingo@xxxxxxx>

Tested and works as advertised for me,

  Ralf
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/