Re: [linux-usb-devel] 2.6.17 hangs during boot on ASUS M2NPV-VMmotherboard

[Andrew Morton]

On Fri, 14 Jul 2006 14:50:16 -0400 (EDT)
Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote:

> On Fri, 14 Jul 2006, Andrew Morton wrote:
> 
> > On Fri, 14 Jul 2006 16:54:25 +0100
> > "Andy Chittenden" <AChittenden@xxxxxxxxxxx> wrote:
> 
> > > > So I guess there's something awry with the USB controller driver?
> > > > 
> > > 
> > > Is there any other info that someone wants to track this down? Or has
> > > someone got a fix?
> 
> It's hard to come up with a fix without knowing what's wrong.  The current 
> development version of that subroutine is essentially the same as the 
> version in 2.6.17.
> 
> If you want to pin down the problem more precisely, try adding a whole 
> bunch of printk() statements to the quirk_usb_handoff_ohci() function in
> drivers/usb/host/pci-quirks.c.
> 

Andy, please add the below, work out what line it gets stuck at and then
let us know?  Thanks.

(bear in mind that our line numbers will usually be different from yours,
so please don't use line numbers to ifdentify where it hung).


diff -puN drivers/usb/host/pci-quirks.c~a drivers/usb/host/pci-quirks.c
--- a/drivers/usb/host/pci-quirks.c~a
+++ a/drivers/usb/host/pci-quirks.c
@@ -164,38 +164,50 @@ static int __devinit mmio_resource_enabl
 	return pci_resource_start(pdev, idx) && mmio_enabled(pdev);
 }
 
+#define D() printk("%s:%d\n", __FILE__, __LINE__);
+
 static void __devinit quirk_usb_handoff_ohci(struct pci_dev *pdev)
 {
 	void __iomem *base;
 
+	D();
+
 	if (!mmio_resource_enabled(pdev, 0))
 		return;
 
+	D();
+
 	base = ioremap_nocache(pci_resource_start(pdev, 0),
 				     pci_resource_len(pdev, 0));
 	if (base == NULL) return;
-
+	D();
 /* On PA-RISC, PDC can leave IR set incorrectly; ignore it there. */
 #ifndef __hppa__
 {
 	u32 control = readl(base + OHCI_CONTROL);
+	D();
 	if (control & OHCI_CTRL_IR) {
 		int wait_time = 500; /* arbitrary; 5 seconds */
+		D();
 		writel(OHCI_INTR_OC, base + OHCI_INTRENABLE);
+		D();
 		writel(OHCI_OCR, base + OHCI_CMDSTATUS);
+		D();
 		while (wait_time > 0 &&
 				readl(base + OHCI_CONTROL) & OHCI_CTRL_IR) {
 			wait_time -= 10;
 			msleep(10);
 		}
+		D();
 		if (wait_time <= 0)
 			printk(KERN_WARNING "%s %s: BIOS handoff "
 					"failed (BIOS bug ?) %08x\n",
 					pdev->dev.bus_id, "OHCI",
 					readl(base + OHCI_CONTROL));
-
+		D();
 		/* reset controller, preserving RWC */
 		writel(control & OHCI_CTRL_RWC, base + OHCI_CONTROL);
+		D();
 	}
 }
 #endif
@@ -203,10 +215,13 @@ static void __devinit quirk_usb_handoff_
 	/*
 	 * disable interrupts
 	 */
+	D();
 	writel(~(u32)0, base + OHCI_INTRDISABLE);
+	D();
 	writel(~(u32)0, base + OHCI_INTRSTATUS);
-
+	D();
 	iounmap(base);
+	D();
 }
 
 static void __devinit quirk_usb_disable_ehci(struct pci_dev *pdev)
_

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/