Re: [PATCH] reiserfs: fix handling of device names with /'s in them

From: Jeffrey Mahoney
Date: Sun Jul 16 2006 - 11:52:43 EST

Hash: SHA1

Hans Reiser wrote:
> So the Plan 9 and Unix way would be to let the driver parse the number
> part of the name after the last slash. What I don't understand is why
> reiserfs is getting involved here, rather than recognizing the driver as
> an extension of the namespace, seeing the driver as a mountpoint, and
> just passing number to the driver. There must be something I don't
> grasp here, can you help me?

The name used in procfs isn't parsed anywhere, it could just as easily
be fs0, fs1, fs2, etc, but that wouldn't be a very user friendly way of
indicating which file system's statistics are described in that
directory. It's just presented to the user as a pathname to identify a
particular file system. The problem is that reiserfs is attempting to
use a name from a separate name space that doesn't follow the same rules
as the standard file system name space. Block device names, initially,
weren't intended for use as self-contained path components and aren't
part of the file system name space. If we wish to use those names, we
need to sanitize them to conform to the rules of the file system name
space by removing/replacing the path separator character.

It's unfortunate that some drivers use a slash rather than sticking with
the <type><letter> convention. I don't expect new drivers to be added
with slashes in them. If at some point the existing drivers are changed
to remove the slash, then this patch can be removed again.

- -Jeff
Version: GnuPG v1.4.3 (Darwin)
Comment: Using GnuPG with Mozilla -

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at