[patch 16/45] PKT_SCHED: Fix error handling while dumping actions

From: Greg KH
Date: Mon Jul 17 2006 - 12:44:23 EST

-stable review patch. If anyone has any objections, please let us know.

From: Thomas Graf <tgraf@xxxxxxx>

"return -err" and blindly inheriting the error code in the netlink
failure exception handler causes errors codes to be returned as
positive value therefore making them being ignored by the caller.

May lead to sending out incomplete netlink messages.

Signed-off-by: Thomas Graf <tgraf@xxxxxxx>
Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
Signed-off-by: Chris Wright <chrisw@xxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
net/sched/act_api.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

--- linux-
+++ linux-
@@ -251,15 +251,17 @@ tcf_action_dump(struct sk_buff *skb, str
RTA_PUT(skb, a->order, 0, NULL);
err = tcf_action_dump_1(skb, a, bind, ref);
if (err < 0)
- goto rtattr_failure;
+ goto errout;
r->rta_len = skb->tail - (u8*)r;

return 0;

+ err = -EINVAL;
skb_trim(skb, b - skb->data);
- return -err;
+ return err;

struct tc_action *tcf_action_init_1(struct rtattr *rta, struct rtattr *est,

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/