Re: [PATCH] panic_on_oops: remove ssleep()

From: Andrew Morton
Date: Mon Jul 17 2006 - 20:22:56 EST


On Mon, 17 Jul 2006 19:10:59 -0400
Horms <horms@xxxxxxxxxxxx> wrote:

> On Tue, Jul 18, 2006 at 12:27:51AM +0200, Andi Kleen wrote:
> > On Monday 17 July 2006 18:17, Horms wrote:
> > ...
> > Keeping the delay might be actually useful so that you can see the panic
> > before system reboots when reboot on panic is enabled. I would just use a loop
> > of mdelays(1) with touch_nmi_watchdog/touch_softirq_watchdog()s
> > inbetween.
>
> Ok, I will look into making that happen. I agree that the pause is
> quite useful.

It's kind-of already implemented, via pause_on_oops. Perhaps doing
something like

if (panic_on_oops)
pause_on_oops = max(pause_on_oops, 5*HZ);

would be sufficient.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/