Re: bttv-driver.c:3964: error: void value not ignored as it ought to be
From: Randy Dunlap
Date: Mon Jul 17 2006 - 23:29:04 EST
> Michael Krufky wrote:
> > Nish Aravamudan wrote:
> >> On 7/17/06, Michael Krufky <mkrufky@xxxxxxxxxxx> wrote:
> >>> Hmmm... This was caused by the "Check all __must_check warnings in
> >>> bttv." patch from Randy Dunlap (cc's from original thread added)
> >>> I am aware that this was done for various reasons of sanity checking,
> >>> however, we cannot check the return value of a void ;-)
> >> For the sanity checking, I don't think video_device_create_file()
> >> should be a void function. It probably should return
> >> class_device_create_file()'s return value, no? As it can fail...
> > You are correct... I was merely pointing out the error, but now I see it
> > runs deeper than I had thought. I will fix both
> > video_device_create_file and video_device_remove_file to return the
> > class_device_foo return values, then I'll push it over to Mauro.
> I was in a rush when I wrote that, and I wasn't thinking.
> video_device_remove_file stays as a void.
> Anyway, here is the fix. This is already in my tree (
> http://linuxtv.org/hg/~mkrufky/v4l-dvb ) but split into separate patches.
Thanks for taking care of this.
I'll look over it and see what I missed. Right now I have
terrible wireless connections/problems. Sorry about the delay.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/