Re: [PATCH] drivers: Conversions from kmalloc+memset to k(z|c)alloc.

From: Pekka Enberg
Date: Wed Jul 19 2006 - 04:36:30 EST


On 7/19/06, Daniel K. <daniel@xxxxxxxxxx> wrote:
> diff --git a/drivers/serial/ip22zilog.c b/drivers/serial/ip22zilog.c
> index 5ff269f..ca0e9f2 100644
> --- a/drivers/serial/ip22zilog.c
> +++ b/drivers/serial/ip22zilog.c
> @@ -925,11 +925,7 @@ static int zilog_irq = -1;
> static void * __init alloc_one_table(unsigned long size)
> {
> void *ret;
> -
> - ret = kmalloc(size, GFP_KERNEL);
> - if (ret != NULL)
> - memset(ret, 0, size);
> -
> + ret = kzalloc(size, GFP_KERNEL);
> return ret;
> }

And here as well.

What is preferred by developers?

That you kill useless wrappers and type casts.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/