Re: [PATCH] libfs: remove page up-to-date check from simple_readpage

From: Pekka J Enberg
Date: Wed Jul 19 2006 - 10:15:17 EST

Uh, oh, removed too much. We obviously need to set the PG_uptodate flag
in simple_readpage(). Sorry about that. Updated patch follows.

From: Pekka Enberg <penberg@xxxxxxxxxxxxxx>

This patch removes the unnecessary PageUptodate check from simple_readpage.
The only two callers for ->readpage that don't have explicit PageUptodate
check are read_cache_pages and page_cache_read which operate on newly
allocated pages which don't have the flag set.

Signed-off-by: Pekka Enberg <penberg@xxxxxxxxxxxxxx>
fs/libfs.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/fs/libfs.c b/fs/libfs.c
index ac02ea6..0d2cc61 100644
--- a/fs/libfs.c
+++ b/fs/libfs.c
@@ -319,15 +319,11 @@ int simple_readpage(struct file *file, s
void *kaddr;

- if (PageUptodate(page))
- goto out;
kaddr = kmap_atomic(page, KM_USER0);
memset(kaddr, 0, PAGE_CACHE_SIZE);
kunmap_atomic(kaddr, KM_USER0);
return 0;

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at