Re: e1000: Problem with "disable CRC stripping workaround" patch

[Mark McLoughlin]

Hi,

On Thu, 2006-07-20 at 09:42 -0700, Auke Kok wrote:
> Mark McLoughlin wrote:
> > Hi Jesse,
> > 	I just came across this:
> > 
> >   http://www.mail-archive.com/netdev@xxxxxxxxxxxxxxx/msg14547.html
> > 
> > 	I'm seeing a problem with this currently under Xen's bridging
> > configuration.

>  > 	One option is to fix this specific problem is to subtract the CRC
>  > length from skb->len in e1000, another is to raise the MTU on the
>  > receive side of Xen's loopback interface. I've attached a patch for the
>  > latter, but I've no real opinion on which is more correct.
> 
> We were sort of expecting this and sent the following patch upstream already - 
> it's already queued for 2.6.18-rc3:
> 
> http://kernel.org/git/?p=linux/kernel/git/jgarzik/netdev-2.6.git;a=commitdiff_plain;h=f235a2abb27b9396d2108dd2987fb8262cb508a3;hp=d3d9e484b2ca502c87156b69fa6b8f8fd5fa18a0
> 
> Please give it a try and let us know if it fixes the issue for you, it should 
> be much better than patching xen's code.

	Yep, this fixes the problem for me.

Thanks,
Mark.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/