Re: [PATCH] drivers: Conversions from kmalloc+memset to k(z|c)alloc.
From: Jesper Juhl
Date: Fri Jul 21 2006 - 06:19:14 EST
On 21/07/06, Stefan Richter <stefanr@xxxxxxxxxxxxxxxxx> wrote:
Jeff Garzik wrote:[snip]
> Pekka Enberg wrote:
>> On 7/21/06, Rolf Eike Beer <eike-kernel@xxxxxxxxx> wrote:
>>> > - if (!(handle = kmalloc(sizeof(struct input_handle), GFP_KERNEL)))
>>> > + handle = kzalloc(sizeof(struct input_handle), GFP_KERNEL);
>>> > + if (!handle)
>>> > return NULL;
>> In general, yes. However, some maintainers don't like that, so I would
>> recommend to keep them as-is unless you get a clear ack from the
>> maintainer to change it.
- check if "sizeof(type)"->"sizeof(*ptr)" is correct
- if yes, change it
- better style of the size argument where correct,
Who says it's "better style" ?
You can argue that sizeof(type) is more readable.
When reading the code you don't have to go lookup the type of ptr in
sizeof(*ptr) before you know what type the code is working with.
Jesper Juhl <jesper.juhl@xxxxxxxxx>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/