Re: [PATCH] drivers: Conversions from kmalloc+memset tok(z|c)alloc.

From: Jeff Garzik
Date: Fri Jul 21 2006 - 17:15:40 EST

Pekka J Enberg wrote:
On Fri, 21 Jul 2006, Panagiotis Issaris wrote:
Ah okay. Up until now, I thought it would be okay to change the style of
the code if it was listed in the CodingStyle document and in any other
cause should be left untouched as it would be left to the maintainers
personal preference. That's why I explicitly asked about the "if ((buf =
kmalloc(...)==NULL) -> buf = kmalloc(...); if (!buf)" type of changes.

Ofcourse, I should have put cosmetic changes in a separate patch anyway.

At least Andrew seems to prefer cleaning up in the same patch. Anyway, I don't think Jeff meant that you shouldn't do any cleanups, but that you should try to respect the existing style as much possible.



To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at