RE: [PATCH] ACPI - change GFP_ATOMIC to GFP_KERNEL for non-atomic allocation

[Brown, Len]

this would oops on a resume from suspend --
when it is called with interrupts off.

-Len 

>-----Original Message-----
>From: Jiri Kosina [mailto:jikos@xxxxxxxx] 
>Sent: Saturday, July 22, 2006 12:16 PM
>To: Brown, Len
>Cc: linux-acpi; linux-kernel@xxxxxxxxxxxxxxx
>Subject: [PATCH] ACPI - change GFP_ATOMIC to GFP_KERNEL for 
>non-atomic allocation
>
>Hi,
>
>drivers/acpi/pci_link.c::acpi_pci_link_set() sets the GFP_ATOMIC for
>kmalloc() allocation for no first-sight obvious reason; as far as I can
>see this is always called outside the atomic/interrupt context, so
>GFP_KERNEL allocation should be used instead.
>
>If applicable, please apply
>
>Signed-off-by: Jiri Kosina <jikos@xxxxxxxx>
>
>--- drivers/acpi/pci_link.c.orig	2006-07-15 
>21:00:43.000000000 +0200
>+++ drivers/acpi/pci_link.c	2006-07-22 17:45:11.000000000 +0200
>@@ -318,7 +318,7 @@ static int acpi_pci_link_set(struct acpi
> 	if (!link || !irq)
> 		return_VALUE(-EINVAL);
> 
>-	resource = kmalloc(sizeof(*resource) + 1, GFP_ATOMIC);
>+	resource = kmalloc(sizeof(*resource) + 1, GFP_KERNEL);
> 	if (!resource)
> 		return_VALUE(-ENOMEM);
> 
> 
>
>-- 
>JiKos.
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/