Re: [PATCH] drivers: Conversions from kmalloc+memset to k(z|c)alloc.

From: Stefan Richter
Date: Sun Jul 23 2006 - 11:23:47 EST

Jeff Garzik wrote:
Tomasz KÅoczko wrote:
Moment .. are you want to say something like "keep commont coding style can't be maintained by tool" ?

Yes and no.

Even if indent watches on to small coding style emenets still I don't see why using this tool isn't one of the current ement of release procedure (?).

indent isn't perfect, _especially_ where C99 comes into the picture.

And running indent across the tree pre-release would (a) create a ton of noise before each release, and (b) undo perfectly valid, readable formatting.

scripts/Lindent exists and gets used, but it is not perfect.


yes, we have scripts/Lindent, but it cannot and is not supposed to solve all style issues. Coding style is about _much_ more than whitespace. It includes sensible names, usage of language features...

Furthermore, much of this thread revolved around style issues where a common coding style is not fully established in the first place.
Stefan Richter
-=====-=-==- -=== =-===
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at