Re: PATCH: Enable binding to local IPv4 IP address for CIFS file system.

[Andi Kleen]

Ben Greear <greearb@xxxxxxxxxxxxxxx> writes:
> 
> diff --git a/fs/cifs/cifsglob.h b/fs/cifs/cifsglob.h
> index 006eb33..1f34c3f 100644
> --- a/fs/cifs/cifsglob.h
> +++ b/fs/cifs/cifsglob.h
> @@ -118,6 +118,7 @@ struct TCP_Server_Info {
>   		struct sockaddr_in sockAddr;
>   		struct sockaddr_in6 sockAddr6;
>   	} addr;
> +	u32 ip4_local_ip; /* if != 0, will bind locally to this IP */

adding a ipv4 only, no ipv6 feature like this at this age seems quite
backwards. If anything you should think of easy expansion to IPv6 at least.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/