Re: [PATCH] fix vmstat per cpu usage

[Andrew Morton]

On Tue, 1 Aug 2006 19:36:21 +0200
Jan Blunck <jblunck@xxxxxxx> wrote:

> The per cpu variables are used incorrectly in vmstat.h.
> 
> Signed-off-by: Jan Blunck <jblunck@xxxxxxx>
> ---
>  include/linux/vmstat.h |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> Index: linux-v2.6.18-rc3/include/linux/vmstat.h
> ===================================================================
> --- linux-v2.6.18-rc3.orig/include/linux/vmstat.h
> +++ linux-v2.6.18-rc3/include/linux/vmstat.h
> @@ -41,23 +41,23 @@ DECLARE_PER_CPU(struct vm_event_state, v
>  
>  static inline void __count_vm_event(enum vm_event_item item)
>  {
> -	__get_cpu_var(vm_event_states.event[item])++;
> +	__get_cpu_var(vm_event_states).event[item]++;
>  }

How odd.  Are there any negative consequences to the existing code?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/