Re: [PATCH 9/33] i386 boot: Add serial output support to the decompressor

[Andi Kleen]

> > /* WARNING!!
> >  * This code is compiled with -fPIC and it is relocated dynamically
> >  * at run time, but no relocation processing is performed.
> >  * This means that it is not safe to place pointers in static structures.
> >  */

iirc the only static relocation in early_printk is the one to initialize
the console pointers - that could certainly be moved to be at run time.
 
> lib/string.c might be useful.  The fact that the functions are not
> static slightly concerns me.  I have a vague memory of non-static
> functions generating relocations for no good reason.

Would surprise me.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/